From: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Date: Mon, 15 Jan 2018 08:23:06 +0000 (+0100)
Subject: [Archive] Synchronously checking access to file
X-Git-Tag: submit/tizen/20180427.125243~15^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9175430071bd60fd15ac65bfd5db1d3fc0d62d41;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git

[Archive] Synchronously checking access to file

[Verification] p.r. is equal to 100% with:
1. commit https://review.tizen.org/gerrit/#/c/166000/
2. added storage privileges to config.xml file
3. allowed the permission request

Change-Id: Ia563e6d1cd9c0229ebe737917889ec0cae085e03
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
---

diff --git a/src/archive/archive_instance.cc b/src/archive/archive_instance.cc
index e42a34c3..cb28a2b3 100644
--- a/src/archive/archive_instance.cc
+++ b/src/archive/archive_instance.cc
@@ -101,9 +101,10 @@ void ArchiveInstance::Open(const picojson::value& args, picojson::object& out) {
   ScopeLogger("%s", args.serialize().c_str());
 
   CHECK_PRIVILEGE_ACCESS(kPrivilegeFilesystemWrite, &out);
-
   picojson::object data = args.get<picojson::object>();
   picojson::value v_file = data.at(PARAM_FILE);
+  CHECK_STORAGE_ACCESS(v_file.get<std::string>(), &out);
+
   picojson::value v_mode = data.at(PARAM_MODE);
   picojson::value v_op_id = data.at(PARAM_OPERATION_ID);
   picojson::object options = data.at(PARAM_OPTIONS).get<picojson::object>();
@@ -260,9 +261,10 @@ void ArchiveInstance::Add(const picojson::value& args, picojson::object& out) {
   ScopeLogger("%s", args.serialize().c_str());
 
   CHECK_PRIVILEGE_ACCESS(kPrivilegeFilesystemWrite, &out);
-
   picojson::object data = args.get<picojson::object>();
   picojson::value v_source = data.at(PARAM_SOURCE_FILE);
+  CHECK_STORAGE_ACCESS(v_source.get<std::string>(), &out);
+
   picojson::value v_options = data.at(PARAM_OPTIONS);
   picojson::value v_op_id = data.at(PARAM_OPERATION_ID);
   picojson::value v_handle = data.at(ARCHIVE_FILE_HANDLE);
@@ -347,9 +349,10 @@ void ArchiveInstance::ExtractAll(const picojson::value& args, picojson::object&
   ScopeLogger("%s", args.serialize().c_str());
 
   CHECK_PRIVILEGE_ACCESS(kPrivilegeFilesystemWrite, &out);
-
   picojson::object data = args.get<picojson::object>();
   picojson::value v_dest_dir = data.at(PARAM_DESTINATION_DIR);
+  CHECK_STORAGE_ACCESS(v_dest_dir.get<std::string>(), &out);
+
   picojson::value v_overwrite = data.at(PARAM_OVERWRITE);
   picojson::value v_op_id = data.at(PARAM_OPERATION_ID);
   picojson::value v_handle = data.at(ARCHIVE_FILE_HANDLE);
@@ -520,9 +523,10 @@ void ArchiveInstance::Extract(const picojson::value& args, picojson::object& out
   ScopeLogger("%s", args.serialize().c_str());
 
   CHECK_PRIVILEGE_ACCESS(kPrivilegeFilesystemWrite, &out);
-
   picojson::object data = args.get<picojson::object>();
   picojson::value v_dest_dir = data.at(PARAM_DESTINATION_DIR);
+  CHECK_STORAGE_ACCESS(v_dest_dir.get<std::string>(), &out);
+
   picojson::value v_strip_name = data.at(PARAM_STRIP_NAME);
   picojson::value v_overwrite = data.at(PARAM_OVERWRITE);
   picojson::value v_op_id = data.at(PARAM_OPERATION_ID);