From: Gustavo A. R. Silva Date: Wed, 28 Nov 2018 04:34:35 +0000 (-0600) Subject: scsi: xen-scsifront: mark expected switch fall-through X-Git-Tag: v5.4-rc1~1940^2~127 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9167f0dcc523735d5df7c6e27b58c05740433657;p=platform%2Fkernel%2Flinux-rpi.git scsi: xen-scsifront: mark expected switch fall-through In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, I replaced "Missed the backend's Closing state -- fallthrough" with "fall through - Missed the backend's Closing state", which contains the "fall through" annotation at the beginnig of the code comment, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva Reviewed-by: Juergen Gross Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c index 61389bd..bb76d0d 100644 --- a/drivers/scsi/xen-scsifront.c +++ b/drivers/scsi/xen-scsifront.c @@ -1112,7 +1112,7 @@ static void scsifront_backend_changed(struct xenbus_device *dev, case XenbusStateClosed: if (dev->state == XenbusStateClosed) break; - /* Missed the backend's Closing state -- fallthrough */ + /* fall through - Missed the backend's Closing state */ case XenbusStateClosing: scsifront_disconnect(info); break;