From: Shravya Kumbham Date: Tue, 10 May 2022 07:12:41 +0000 (+0530) Subject: dmaengine: zynqmp_dma: check dma_async_device_register return value X-Git-Tag: v6.6.17~7400^2~36 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9126518e0439bc4b47b15d0da42f0cdba7a74b3a;p=platform%2Fkernel%2Flinux-rpi.git dmaengine: zynqmp_dma: check dma_async_device_register return value Add condition to check the return value of dma_async_device_register and implement its error handling. Addresses-Coverity: Event check_return. Signed-off-by: Shravya Kumbham Signed-off-by: Harini Katakam Signed-off-by: Radhey Shyam Pandey Link: https://lore.kernel.org/r/1652166762-18317-3-git-send-email-radhey.shyam.pandey@xilinx.com Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c index 3ffa7f3..915dbe6 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -1094,7 +1094,11 @@ static int zynqmp_dma_probe(struct platform_device *pdev) p->dst_addr_widths = BIT(zdev->chan->bus_width / 8); p->src_addr_widths = BIT(zdev->chan->bus_width / 8); - dma_async_device_register(&zdev->common); + ret = dma_async_device_register(&zdev->common); + if (ret) { + dev_err(zdev->dev, "failed to register the dma device\n"); + goto free_chan_resources; + } ret = of_dma_controller_register(pdev->dev.of_node, of_zynqmp_dma_xlate, zdev);