From: Vedant Kumar <vsk@apple.com>
Date: Mon, 10 Jul 2017 21:44:43 +0000 (+0000)
Subject: InstrProf: Fix unit test which accidentally used a duplicate name
X-Git-Tag: llvmorg-5.0.0-rc1~805
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=910d3d0541f0cada8308da43d81bff721cdbba99;p=platform%2Fupstream%2Fllvm.git

InstrProf: Fix unit test which accidentally used a duplicate name

This unit test constructed some profile records incorrectly. One of the
records had a duplicate name: adding that record into the writer caused
an error unrelated to what needed to be tested.

Reported by David Blaikie!

llvm-svn: 307596
---

diff --git a/llvm/unittests/ProfileData/InstrProfTest.cpp b/llvm/unittests/ProfileData/InstrProfTest.cpp
index 71795b0..79f880e 100644
--- a/llvm/unittests/ProfileData/InstrProfTest.cpp
+++ b/llvm/unittests/ProfileData/InstrProfTest.cpp
@@ -996,10 +996,7 @@ TEST_P(MaybeSparseInstrProfTest, instr_prof_symtab_compression_test) {
 TEST_F(SparseInstrProfTest, preserve_no_records) {
   Writer.addRecord({"foo", 0x1234, {0}}, Err);
   Writer.addRecord({"bar", 0x4321, {0, 0}}, Err);
-  // FIXME: I'm guessing this data should be different, but the original author
-  // should check/update this test so it doesn't produce errors.
-  Writer.addRecord({"bar", 0x4321, {0, 0, 0}},
-                   [](Error E) { consumeError(std::move(E)); });
+  Writer.addRecord({"baz", 0x4321, {0, 0, 0}}, Err);
 
   auto Profile = Writer.writeBuffer();
   readProfile(std::move(Profile));