From: YueHaibing Date: Thu, 28 Feb 2019 12:24:59 +0000 (+0800) Subject: drm/nouveau/debugfs: Fix check of pm_runtime_get_sync failure X-Git-Tag: v5.4-rc1~1356^2~4^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=909e9c9c428376e2a43d178ed4b0a2d5ba9cb7d3;p=platform%2Fkernel%2Flinux-rpi.git drm/nouveau/debugfs: Fix check of pm_runtime_get_sync failure pm_runtime_get_sync returns negative on failure. Fixes: eaeb9010bb4b ("drm/nouveau/debugfs: Wake up GPU before doing any reclocking") Signed-off-by: YueHaibing Signed-off-by: Ben Skeggs --- diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/nouveau_debugfs.c index 88a52f6..7dfbbbc 100644 --- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c +++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c @@ -181,7 +181,7 @@ nouveau_debugfs_pstate_set(struct file *file, const char __user *ubuf, } ret = pm_runtime_get_sync(drm->dev); - if (IS_ERR_VALUE(ret) && ret != -EACCES) + if (ret < 0 && ret != -EACCES) return ret; ret = nvif_mthd(ctrl, NVIF_CONTROL_PSTATE_USER, &args, sizeof(args)); pm_runtime_put_autosuspend(drm->dev);