From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 19 Nov 2014 15:33:17 +0000 (+0100)
Subject: drm/edid: Deletion of an unnecessary check before the function call "release_firmware"
X-Git-Tag: v3.19-rc1~73^2~33
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9084acf19bb98afb0ed90337fd39541103fe3494;p=platform%2Fkernel%2Flinux-exynos.git

drm/edid: Deletion of an unnecessary check before the function call "release_firmware"

The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
---

diff --git a/drivers/gpu/drm/drm_edid_load.c b/drivers/gpu/drm/drm_edid_load.c
index 0a235fe..732cb6f 100644
--- a/drivers/gpu/drm/drm_edid_load.c
+++ b/drivers/gpu/drm/drm_edid_load.c
@@ -254,8 +254,7 @@ static void *edid_load(struct drm_connector *connector, const char *name,
 	    name, connector_name);
 
 out:
-	if (fw)
-		release_firmware(fw);
+	release_firmware(fw);
 	return edid;
 }