From: Richard Weinberger <richard@nod.at>
Date: Mon, 1 Jun 2015 21:10:49 +0000 (+0200)
Subject: mtd: r852: Fix device_create_file() usage
X-Git-Tag: v4.14-rc1~4036^2~394
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=905cce7f4309f3ec19c1ed67edd68b7e67e88f3e;p=platform%2Fkernel%2Flinux-rpi.git

mtd: r852: Fix device_create_file() usage

device_create_file() can fail, therefore we have to
handle this case and abort.

Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---

diff --git a/drivers/mtd/nand/r852.c b/drivers/mtd/nand/r852.c
index baea83f..77e96d2 100644
--- a/drivers/mtd/nand/r852.c
+++ b/drivers/mtd/nand/r852.c
@@ -653,11 +653,15 @@ static int r852_register_nand_device(struct r852_device *dev)
 	if (sm_register_device(dev->mtd, dev->sm))
 		goto error2;
 
-	if (device_create_file(&dev->mtd->dev, &dev_attr_media_type))
+	if (device_create_file(&dev->mtd->dev, &dev_attr_media_type)) {
 		message("can't create media type sysfs attribute");
+		goto error3;
+	}
 
 	dev->card_registred = 1;
 	return 0;
+error3:
+	nand_release(dev->mtd);
 error2:
 	kfree(dev->mtd);
 error1: