From: Iago Toral Quiroga Date: Tue, 19 Dec 2017 12:30:14 +0000 (+0100) Subject: Validate instancing cases properly X-Git-Tag: upstream/1.3.5~852^2~81 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9023e4dfc45ff34b437cf8a97dfc5d2287c515b6;p=platform%2Fupstream%2FVK-GL-CTS.git Validate instancing cases properly The vertex attrib 64bit limits test case executes both regular and instanced draw calls and has a validation function that takes a boolean parameter that informs it about whether isntancing has been used so it can verify that all instances executed properly. However, this function is always called with false as parameter, indicating no instancing, even for instanced scenarios, which means that the validation function is only validating the first instance even for instanced cases. Components: OpenGL VK-GL-CTS issue: 916 Affects: KHR-GL45.vertex_attrib_64bit.limits_test KHR-GL46.vertex_attrib_64bit.limits_test Change-Id: Ibaf2c8fc0b6599a17f7bdbc7c4914b42d38d5e2a --- diff --git a/external/openglcts/modules/gl/gl4cVertexAttrib64BitTest.cpp b/external/openglcts/modules/gl/gl4cVertexAttrib64BitTest.cpp index 9d4c4f5..0b2823b 100644 --- a/external/openglcts/modules/gl/gl4cVertexAttrib64BitTest.cpp +++ b/external/openglcts/modules/gl/gl4cVertexAttrib64BitTest.cpp @@ -2598,7 +2598,7 @@ bool LimitTest::testDrawArraysInstanced() const gl.endTransformFeedback(); GLU_EXPECT_NO_ERROR(gl.getError(), "EndTransformFeedback"); - if (true == verifyResult(false)) + if (true == verifyResult(true)) { return true; } @@ -2652,7 +2652,7 @@ bool LimitTest::testDrawElementsInstanced() const gl.endTransformFeedback(); GLU_EXPECT_NO_ERROR(gl.getError(), "EndTransformFeedback"); - if (true == verifyResult(false)) + if (true == verifyResult(true)) { return true; }