From: Steve French <stfrench@microsoft.com>
Date: Fri, 28 Feb 2020 07:32:37 +0000 (-0600)
Subject: cifs: print warning mounting with vers=1.0
X-Git-Tag: v5.10.7~2955^2~21
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8fe0c2c2cb7be631576637555d712247bc86f1bf;p=platform%2Fkernel%2Flinux-rpi.git

cifs: print warning mounting with vers=1.0

We really, really don't want people using insecure dialects
unless they realize what they are doing ...

Add mount warning if mounting with vers=1.0 (older SMB1/CIFS
dialect) instead of the default (SMB2.1 or later, typically
SMB3.1.1).

Signed-off-by: Steve French <stfrench@microsoft.com>
Acked-by: Ronnie Sahlberg <lsahlber@redhat.com>
Acked-by: Pavel Shilovsky <pshilov@microsoft.com>
---

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index f4d12b7..46b602d 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -1471,6 +1471,9 @@ cifs_parse_smb_version(char *value, struct smb_vol *vol, bool is_smb3)
 			cifs_dbg(VFS, "vers=1.0 (cifs) not permitted when mounting with smb3\n");
 			return 1;
 		}
+		cifs_dbg(VFS, "Use of the less secure dialect vers=1.0 "
+			   "is not recommended unless required for "
+			   "access to very old servers\n");
 		vol->ops = &smb1_operations;
 		vol->vals = &smb1_values;
 		break;