From: Heinrich Schuchardt Date: Sun, 18 Mar 2018 11:41:43 +0000 (+0100) Subject: spi: atcspi200: avoid NULL dereference X-Git-Tag: v2018.07-rc1~27^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8fad5e0b114fdd4c4e8d5f105ea3527df2c83986;p=platform%2Fkernel%2Fu-boot.git spi: atcspi200: avoid NULL dereference For SPI_XFER_BEGIN | SPI_XFER_END the code sets data_out = NULL. In the debug statement we should not dereference this value. As we do not transfer any data the debug statement is not needed in this case anyway. Signed-off-by: Heinrich Schuchardt Reviewed-by: Jagan Teki --- diff --git a/drivers/spi/atcspi200_spi.c b/drivers/spi/atcspi200_spi.c index 2c1d36e..6233d49 100644 --- a/drivers/spi/atcspi200_spi.c +++ b/drivers/spi/atcspi200_spi.c @@ -229,8 +229,10 @@ static int __atcspi200_spi_xfer(struct nds_spi_slave *ns, __atcspi200_spi_start(ns); break; } - debug("spi_xfer: data_out %08X(%p) data_in %08X(%p) data_len %u\n", - *(uint *)data_out, data_out, *(uint *)data_in, data_in, data_len); + if (data_out) + debug("spi_xfer: data_out %08X(%p) data_in %08X(%p) data_len %u\n", + *(uint *)data_out, data_out, *(uint *)data_in, + data_in, data_len); num_chunks = DIV_ROUND_UP(data_len, max_tran_len); din = data_in; dout = data_out;