From: Samuel Pitoiset Date: Mon, 11 Jan 2021 08:20:48 +0000 (+0100) Subject: radv: fix crashes when fast-clearing in a secondary command buffer X-Git-Tag: upstream/21.0.0~444 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8f9b2afe7075d07bbeacb238f144240f2f68d13b;p=platform%2Fupstream%2Fmesa.git radv: fix crashes when fast-clearing in a secondary command buffer iview can be NULL inside a secondary command buffer. Fixes: 00064713a30 ("radv: determine at creation if an image view can be fast cleared") Signed-off-by: Samuel Pitoiset Reviewed-by: Timur Kristóf Part-of: --- diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c index 2c3dfb5..4461ba4 100644 --- a/src/amd/vulkan/radv_meta_clear.c +++ b/src/amd/vulkan/radv_meta_clear.c @@ -1001,7 +1001,7 @@ radv_can_fast_clear_depth(struct radv_cmd_buffer *cmd_buffer, const VkClearDepthStencilValue clear_value, uint32_t view_mask) { - if (!iview->support_fast_clear) + if (!iview || !iview->support_fast_clear) return false; if (!radv_layout_is_htile_compressed(cmd_buffer->device, iview->image, image_layout, in_render_loop, @@ -1571,7 +1571,7 @@ radv_can_fast_clear_color(struct radv_cmd_buffer *cmd_buffer, { uint32_t clear_color[2]; - if (!iview->support_fast_clear) + if (!iview || !iview->support_fast_clear) return false; if (!radv_layout_can_fast_clear(cmd_buffer->device, iview->image, image_layout, in_render_loop,