From: Jan Kara <jack@suse.cz>
Date: Thu, 30 Oct 2014 14:53:16 +0000 (-0400)
Subject: ext4: fix oops when loading block bitmap failed
X-Git-Tag: v3.4.106~66
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8f71a69fa42f842824e488be11c84af325e5feac;p=platform%2Fkernel%2Flinux-stable.git

ext4: fix oops when loading block bitmap failed

commit 599a9b77ab289d85c2d5c8607624efbe1f552b0f upstream.

When we fail to load block bitmap in __ext4_new_inode() we will
dereference NULL pointer in ext4_journal_get_write_access(). So check
for error from ext4_read_block_bitmap().

Coverity-id: 989065
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Zefan Li <lizefan@huawei.com>
---

diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index 75c4f36bced8..97ca4b6fb2a9 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -725,6 +725,10 @@ got:
 		struct buffer_head *block_bitmap_bh;
 
 		block_bitmap_bh = ext4_read_block_bitmap(sb, group);
+		if (!block_bitmap_bh) {
+			err = -EIO;
+			goto out;
+		}
 		BUFFER_TRACE(block_bitmap_bh, "get block bitmap access");
 		err = ext4_journal_get_write_access(handle, block_bitmap_bh);
 		if (err) {