From: Yuni Jeong Date: Wed, 10 Jul 2013 06:31:25 +0000 (+0900) Subject: Fixed somtimes focus ring is shown twice. X-Git-Tag: submit/tizen_2.2/20130714.131554~13 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8f566ef0c2e5690f430f3a7e1a6a943e3efb6856;hp=17cf3620bd51a9bf310617edfe0625f0e84af476;p=framework%2Fweb%2Fwebkit-efl.git Fixed somtimes focus ring is shown twice. [Title] Fixed somtimes focus ring is shown twice. [Issue#] N/A [Problem] Somtimes, focus ring is shown twice. [Cause] When tap is performed in handleGestureEvent() function, although timer for showing focus ring has expired(focus ring had already shown and hidden), function to show focus ring is called again. [Solution] When tap is performed in handleGestureEvent() function, if timer for showing focus ring has expired(focus ring had already shown and hidden), focus ring is not shown again. Change-Id: Ia7a9802c8228d510a184c13d9cc6ae5ab670bee6 --- diff --git a/Source/WebKit2/UIProcess/API/efl/tizen/FocusRing.cpp b/Source/WebKit2/UIProcess/API/efl/tizen/FocusRing.cpp index 14bf75a..e7782ff 100755 --- a/Source/WebKit2/UIProcess/API/efl/tizen/FocusRing.cpp +++ b/Source/WebKit2/UIProcess/API/efl/tizen/FocusRing.cpp @@ -82,16 +82,18 @@ void FocusRing::requestToShow(const IntPoint& position, bool immediately) if (immediately) { if (m_focusRingObject && evas_object_visible_get(m_focusRingObject)) return; - else { - if (m_showTimer) { - ecore_timer_del(m_showTimer); - m_showTimer = 0; - } - m_position = position; - show(IntRect()); + if (!m_showTimer) return; + + if (m_showTimer) { + ecore_timer_del(m_showTimer); + m_showTimer = 0; } + + m_position = position; + show(IntRect()); + return; } m_position = position;