From: Sebastian Rasmussen Date: Sat, 9 Aug 2014 11:22:42 +0000 (+0200) Subject: directsoundsrc: Avoid leaking copy of caps object X-Git-Tag: accepted/tizen/unified/20220217.153506~2^2~10^2~9^2~12^2~2^2~274 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8f48e72a7cf1ff8f00a4882d918c5119d83b1e54;p=platform%2Fupstream%2Fgstreamer.git directsoundsrc: Avoid leaking copy of caps object gst_pad_get_pad_template_caps() returns a reference which is unreferenced, so creating a copy using gst_caps_copy() results in a reference leak. Fixes https://bugzilla.gnome.org/show_bug.cgi?id=734536 --- diff --git a/sys/directsound/gstdirectsoundsrc.c b/sys/directsound/gstdirectsoundsrc.c index 11063ca..420a70d 100644 --- a/sys/directsound/gstdirectsoundsrc.c +++ b/sys/directsound/gstdirectsoundsrc.c @@ -201,8 +201,7 @@ gst_directsound_src_getcaps (GstBaseSrc * bsrc, GstCaps * filter) GstCaps *caps = NULL; GST_DEBUG_OBJECT (bsrc, "get caps"); - caps = gst_caps_copy (gst_pad_get_pad_template_caps (GST_BASE_SRC_PAD - (bsrc))); + caps = gst_pad_get_pad_template_caps (GST_BASE_SRC_PAD (bsrc)); return caps; }