From: Joe Loser <joeloser93@gmail.com>
Date: Tue, 8 Feb 2022 02:33:11 +0000 (-0500)
Subject: [libc++] Use _LIBCPP_NO_UNIQUE_ADDRESS for base in join_view
X-Git-Tag: upstream/15.0.7~16752
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8f0b2ac140c36f37597deef66bea8a7739c18a7b;p=platform%2Fupstream%2Fllvm.git

[libc++] Use _LIBCPP_NO_UNIQUE_ADDRESS for base in join_view

Despite the comment saying `[[no_unique_address]]` on the `__base_` data member
makes clang crash, this does not seem to be true on CI. So, mark `__base_` with
`_LIBCPP_NO_UNIQUE_ADDRESS`.

Differential Revision: https://reviews.llvm.org/D119208
---

diff --git a/libcxx/include/__ranges/join_view.h b/libcxx/include/__ranges/join_view.h
index 1af2221..4bab8df 100644
--- a/libcxx/include/__ranges/join_view.h
+++ b/libcxx/include/__ranges/join_view.h
@@ -68,7 +68,7 @@ namespace ranges {
     static constexpr bool _UseCache = !is_reference_v<_InnerRange>;
     using _Cache = _If<_UseCache, __non_propagating_cache<remove_cvref_t<_InnerRange>>, __empty_cache>;
     _LIBCPP_NO_UNIQUE_ADDRESS _Cache __cache_;
-    _View __base_ = _View(); // TODO: [[no_unique_address]] makes clang crash! File a bug :)
+    _LIBCPP_NO_UNIQUE_ADDRESS _View __base_ = _View();
 
   public:
     _LIBCPP_HIDE_FROM_ABI