From: Duncan P. N. Exon Smith <dexonsmith@apple.com>
Date: Wed, 20 Apr 2016 18:27:18 +0000 (+0000)
Subject: Verifier: Prefer early continue over if-nesting, NFC
X-Git-Tag: llvmorg-3.9.0-rc1~8563
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8ec8da40a860b7e0dca0b6fe7d4b1e6821630f01;p=platform%2Fupstream%2Fllvm.git

Verifier: Prefer early continue over if-nesting, NFC

llvm-svn: 266897
---

diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp
index f010fd3..e643dff 100644
--- a/llvm/lib/IR/Verifier.cpp
+++ b/llvm/lib/IR/Verifier.cpp
@@ -258,15 +258,16 @@ public:
       return false;
     }
     for (const BasicBlock &BB : F) {
-      if (BB.empty() || !BB.back().isTerminator()) {
-        if (OS) {
-          *OS << "Basic Block in function '" << F.getName()
-              << "' does not have terminator!\n";
-          BB.printAsOperand(*OS, true);
-          *OS << "\n";
-        }
-        return false;
+      if (!BB.empty() && BB.back().isTerminator())
+        continue;
+
+      if (OS) {
+        *OS << "Basic Block in function '" << F.getName()
+            << "' does not have terminator!\n";
+        BB.printAsOperand(*OS, true);
+        *OS << "\n";
       }
+      return false;
     }
 
     // Now directly compute a dominance tree. We don't rely on the pass