From: Panu Matilainen Date: Thu, 1 Apr 2010 15:19:49 +0000 (+0300) Subject: Nuke bogus comments + related NULL-checks X-Git-Tag: tznext/4.11.0.1.tizen20130304~2048 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8e9d2aff44af79260c0adec976773dd78c4dc1b8;p=tools%2Flibrpm-tizen.git Nuke bogus comments + related NULL-checks - db->_dbi cannot be NULL if db is not NULL, it's allocated at newRpmDB() and freed in rpmdbClose() and nothing else touches it --- diff --git a/lib/rpmdb.c b/lib/rpmdb.c index f67f044..86c4dae 100644 --- a/lib/rpmdb.c +++ b/lib/rpmdb.c @@ -139,7 +139,6 @@ static dbiIndex rpmdbOpenIndex(rpmdb db, rpmTag rpmtag, unsigned int flags) return NULL; /* Is this index already open ? */ - /* FIX: db->_dbi may be NULL */ if ((dbi = db->_dbi[dbix]) != NULL) return dbi; @@ -188,7 +187,6 @@ static dbiIndex rpmdbOpenIndex(rpmdb db, rpmTag rpmtag, unsigned int flags) dbi = dbiFree(dbi); } -/* FIX: db->_dbi may be NULL */ return dbi; } @@ -641,7 +639,6 @@ int rpmdbClose(rpmdb db) if (db->nrefs > 0) goto exit; - if (db->_dbi) for (int dbix = dbiTagsMax; --dbix >= 0; ) { int xx; if (db->_dbi[dbix] == NULL) @@ -855,13 +852,11 @@ int rpmdbVerify(const char * prefix) for (int dbix = dbiTagsMax; --dbix >= 0; ) { if (db->_dbi[dbix] == NULL) continue; - /* FIX: double indirection. */ xx = dbiVerify(db->_dbi[dbix], 0); if (xx && rc == 0) rc = xx; db->_dbi[dbix] = NULL; } - /* FIX: db->_dbi[] may be NULL. */ xx = rpmdbClose(db); if (xx && rc == 0) rc = xx; db = NULL;