From: Yoshihiro Shimoda Date: Mon, 26 Dec 2022 07:13:27 +0000 (+0900) Subject: net: ethernet: renesas: rswitch: Fix error path in renesas_eth_sw_probe() X-Git-Tag: v6.6.17~5811^2~35^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8e6a8d7a3dd93e93645be061692cb4ee6702dff0;p=platform%2Fkernel%2Flinux-rpi.git net: ethernet: renesas: rswitch: Fix error path in renesas_eth_sw_probe() If rswitch_init() returns non-zero and this driver is re-probed, the following error happens: renesas_eth_sw e6880000.ethernet: Unbalanced pm_runtime_enable! So, fix error path in renesas_eth_sw_probe(). Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"") Signed-off-by: Yoshihiro Shimoda Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c index e42ceaa..473d86b 100644 --- a/drivers/net/ethernet/renesas/rswitch.c +++ b/drivers/net/ethernet/renesas/rswitch.c @@ -1786,6 +1786,11 @@ static int renesas_eth_sw_probe(struct platform_device *pdev) pm_runtime_get_sync(&pdev->dev); ret = rswitch_init(priv); + if (ret < 0) { + pm_runtime_put(&pdev->dev); + pm_runtime_disable(&pdev->dev); + return ret; + } device_set_wakeup_capable(&pdev->dev, 1);