From: chrisnas Date: Sun, 2 Sep 2018 17:17:31 +0000 (+0200) Subject: Add modules to the heap only dump in order to have: (dotnet/coreclr#19761) X-Git-Tag: submit/tizen/20210909.063632~11030^2~3990 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8e605e9139be37c29e641f76f4695cacf55a8e7a;p=platform%2Fupstream%2Fdotnet%2Fruntime.git Add modules to the heap only dump in order to have: (dotnet/coreclr#19761) + types in with sos.dumpheap -stat instead of UNKNOWN + complete stack with sos.dumpstack On a dual core machine, full=11GB, withheap=226MB, withheap(+patch)=269MB Commit migrated from https://github.com/dotnet/coreclr/commit/0821f6f06f34146053356bf944d01aff086bb312 --- diff --git a/src/coreclr/src/debug/createdump/crashinfo.cpp b/src/coreclr/src/debug/createdump/crashinfo.cpp index 8064691..6de6b94 100644 --- a/src/coreclr/src/debug/createdump/crashinfo.cpp +++ b/src/coreclr/src/debug/createdump/crashinfo.cpp @@ -197,6 +197,10 @@ CrashInfo::GatherCrashInfo(MINIDUMP_TYPE minidumpType) // Add all the heap (read/write) memory regions (m_otherMappings contains the heaps) else if (minidumpType & MiniDumpWithPrivateReadWriteMemory) { + for (const MemoryRegion& region : m_moduleMappings) + { + InsertMemoryBackedRegion(region); + } for (const MemoryRegion& region : m_otherMappings) { if (region.Permissions() == (PF_R | PF_W))