From: Dan Carpenter <error27@gmail.com>
Date: Fri, 2 Apr 2010 11:30:10 +0000 (-0300)
Subject: V4L/DVB: cx231xx: improve error handling
X-Git-Tag: v3.12-rc1~10285^2~179
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8e47567f7d24346980f109d7eaed083106ff170d;p=kernel%2Fkernel-generic.git

V4L/DVB: cx231xx: improve error handling

Return -EINVAL if we don't find the control id.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

diff --git a/drivers/media/video/cx231xx/cx231xx-video.c b/drivers/media/video/cx231xx/cx231xx-video.c
index 16a73ea..597c416 100644
--- a/drivers/media/video/cx231xx/cx231xx-video.c
+++ b/drivers/media/video/cx231xx/cx231xx-video.c
@@ -1902,9 +1902,12 @@ static int radio_queryctrl(struct file *file, void *priv,
 	if (c->id < V4L2_CID_BASE || c->id >= V4L2_CID_LASTP1)
 		return -EINVAL;
 	if (c->id == V4L2_CID_AUDIO_MUTE) {
-		for (i = 0; i < CX231XX_CTLS; i++)
+		for (i = 0; i < CX231XX_CTLS; i++) {
 			if (cx231xx_ctls[i].v.id == c->id)
 				break;
+		}
+		if (i == CX231XX_CTLS)
+			return -EINVAL;
 		*c = cx231xx_ctls[i].v;
 	} else
 		*c = no_ctl;