From: Tomasz Marciniak Date: Wed, 4 Nov 2015 11:25:16 +0000 (+0100) Subject: Revert "[power] - checking privileges moved to JS layer" X-Git-Tag: submit/tizen_mobile/20151215.080542^2~14 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8e01caa710c8a3f792fa242b0455d9d4b120444d;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git Revert "[power] - checking privileges moved to JS layer" This reverts commit a5b3b23a7fcee681a24e974c1b1a10a7b876d9b5. [Verification] Code compiles.5 TCTs fail because: "CurrentBrightness, CustomBrightness is not declare at org.tizen.system.deviced.display." Change-Id: I7e87e50de3054e96e900a4687b38fb946456f1d3 Signed-off-by: Tomasz Marciniak --- diff --git a/src/power/power_api.js b/src/power/power_api.js index bb049c16..d74fba31 100755 --- a/src/power/power_api.js +++ b/src/power/power_api.js @@ -15,7 +15,6 @@ */ var validator_ = xwalk.utils.validator; -var privilege_ = xwalk.utils.privilege; var types_ = validator_.Types; var native_ = new xwalk.utils.NativeManager(extension); @@ -121,8 +120,6 @@ function PowerManager() { * is desired to be. */ PowerManager.prototype.request = function(resource, state) { - xwalk.utils.checkPrivilegeAccess(privilege_.POWER); - var args = validator_.validateArgs(arguments, [ {'name' : 'resource', 'type': types_.ENUM, 'values' : ['SCREEN', 'CPU']}, {'name' : 'state', 'type': types_.ENUM, 'values' : ['SCREEN_OFF', 'SCREEN_DIM', 'SCREEN_NORMAL', 'SCREEN_BRIGHT', 'CPU_AWAKE']} @@ -216,8 +213,6 @@ PowerManager.prototype.getScreenBrightness = function() { * @param {!number} brightness The screen brightness value to set. */ PowerManager.prototype.setScreenBrightness = function(brightness) { - xwalk.utils.checkPrivilegeAccess(privilege_.POWER); - var args = validator_.validateArgs(arguments, [ {'name' : 'brightness', 'type': types_.DOUBLE} ]); @@ -274,8 +269,6 @@ PowerManager.prototype.restoreScreenBrightness = function() { * Turns on the screen. */ PowerManager.prototype.turnScreenOn = function() { - xwalk.utils.checkPrivilegeAccess(privilege_.POWER); - var nativeParam = { }; @@ -291,8 +284,6 @@ PowerManager.prototype.turnScreenOn = function() { * Turns off the screen. */ PowerManager.prototype.turnScreenOff = function() { - xwalk.utils.checkPrivilegeAccess(privilege_.POWER); - var nativeParam = { }; diff --git a/src/power/power_instance.cc b/src/power/power_instance.cc index dc6fe901..a4b566de 100755 --- a/src/power/power_instance.cc +++ b/src/power/power_instance.cc @@ -25,6 +25,7 @@ #include "common/picojson.h" #include "common/logger.h" #include "common/platform_exception.h" +#include "common/tools.h" #include "power_manager.h" @@ -32,6 +33,9 @@ namespace extension { namespace power { namespace { +// The privileges that required in Power API +const std::string kPrivilegePower = "http://tizen.org/privilege/power"; + const std::map kPowerResourceMap = { {"SCREEN", POWER_RESOURCE_SCREEN}, {"CPU", POWER_RESOURCE_CPU} @@ -94,6 +98,8 @@ enum PowerCallbacks { void PowerInstance::PowerManagerRequest(const picojson::value& args, picojson::object& out) { LoggerD("Enter"); + CHECK_PRIVILEGE_ACCESS(kPrivilegePower, &out); + const std::string& resource = args.get("resource").get(); const std::string& state = args.get("state").get(); @@ -132,6 +138,8 @@ void PowerInstance::PowerManagerGetscreenbrightness(const picojson::value& args, void PowerInstance::PowerManagerSetscreenbrightness(const picojson::value& args, picojson::object& out) { LoggerD("Enter"); + CHECK_PRIVILEGE_ACCESS(kPrivilegePower, &out); + CHECK_EXIST(args, "brightness", out) double brightness = args.get("brightness").get(); @@ -165,6 +173,8 @@ void PowerInstance::PowerManagerRestorescreenbrightness(const picojson::value& a void PowerInstance::PowerManagerTurnscreenon(const picojson::value& args, picojson::object& out) { LoggerD("Enter"); + CHECK_PRIVILEGE_ACCESS(kPrivilegePower, &out); + PlatformResult result = PowerManager::GetInstance()->SetScreenState(true); if (result.IsError()) LogAndReportError(result, &out); @@ -174,6 +184,8 @@ void PowerInstance::PowerManagerTurnscreenon(const picojson::value& args, picojs void PowerInstance::PowerManagerTurnscreenoff(const picojson::value& args, picojson::object& out) { LoggerD("Enter"); + CHECK_PRIVILEGE_ACCESS(kPrivilegePower, &out); + PlatformResult result = PowerManager::GetInstance()->SetScreenState(false); if (result.IsError()) LogAndReportError(result, &out);