From: Sangchul Lee <sc11.lee@samsung.com>
Date: Tue, 24 Aug 2021 08:14:16 +0000 (+0900)
Subject: webrtc_private: Remove workaround codes regarding negotiation needed callback
X-Git-Tag: submit/tizen/20210825.083902^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8dffe85fd0b18002e468595d256a380e15771f51;p=platform%2Fcore%2Fapi%2Fwebrtc.git

webrtc_private: Remove workaround codes regarding negotiation needed callback

[Version] 0.2.81
[Issue Type] Improvement

Change-Id: I9e1686e858b3c7ae25976af2ed5ff9fde482d040
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
---

diff --git a/include/webrtc_private.h b/include/webrtc_private.h
index 6b2ad59c..9c0fbcc3 100644
--- a/include/webrtc_private.h
+++ b/include/webrtc_private.h
@@ -412,11 +412,6 @@ typedef struct _webrtc_s {
 
 	webrtc_callbacks_s stats_cb;
 
-	/* FIXME: Once signal is emitted by webrtcbin, it'll not be triggered
-	 * even if the pipeline state is changed to NULL to PLAYING again.
-	 * This variable could be removed, some improvements are applied to webrtcbin. */
-	bool negotiation_needed_cb_invoked;
-
 	webrtc_negotiation_states_s negotiation_states;
 #ifndef TIZEN_TV
 	webrtc_resource_s resource;
diff --git a/packaging/capi-media-webrtc.spec b/packaging/capi-media-webrtc.spec
index 64acc98d..3891412d 100644
--- a/packaging/capi-media-webrtc.spec
+++ b/packaging/capi-media-webrtc.spec
@@ -1,6 +1,6 @@
 Name:       capi-media-webrtc
 Summary:    A WebRTC library in Tizen Native API
-Version:    0.2.80
+Version:    0.2.81
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
diff --git a/src/webrtc_private.c b/src/webrtc_private.c
index 33095653..279c158b 100644
--- a/src/webrtc_private.c
+++ b/src/webrtc_private.c
@@ -206,14 +206,11 @@ static gchar *__make_ice_candidate_message(guint mlineindex, gchar *candidate)
 	return text;
 }
 
-static bool __meet_gst_state(webrtc_state_e state, GstState gst_state, bool negotiation_needed_cb_invoked)
+static bool __meet_gst_state(webrtc_state_e state, GstState gst_state)
 {
 	if (state == WEBRTC_STATE_IDLE && gst_state == GST_STATE_READY)
 		return true;
 
-	if (state == WEBRTC_STATE_NEGOTIATING && gst_state == GST_STATE_PLAYING && negotiation_needed_cb_invoked)
-		return true;
-
 	return false;
 }
 
@@ -363,7 +360,7 @@ static gboolean __bus_watch_cb(GstBus *bus, GstMessage *message, gpointer user_d
 			break;
 		}
 
-		if (__meet_gst_state(webrtc->pend_state, gst_state_new, webrtc->negotiation_needed_cb_invoked)) {
+		if (__meet_gst_state(webrtc->pend_state, gst_state_new)) {
 			webrtc_state_e old_state = webrtc->state;
 			webrtc->state = webrtc->pend_state;
 			g_clear_pointer(&locker, g_mutex_locker_free);
@@ -792,7 +789,6 @@ static void __webrtcbin_on_negotiation_needed_cb(GstElement *webrtcbin, gpointer
 	RET_IF(webrtc == NULL, "webrtc is NULL");
 
 	_post_state_cb_in_idle(webrtc, WEBRTC_STATE_NEGOTIATING);
-	webrtc->negotiation_needed_cb_invoked = true;
 
 	if (webrtc->negotiation_needed_cb.callback == NULL) {
 		LOG_DEBUG("negotiation_needed_cb is NULL, skip it");