From: Simon Glass Date: Sun, 1 May 2016 19:55:37 +0000 (-0600) Subject: image-fit: Don't display an error in fit_set_timestamp() X-Git-Tag: v2016.07-rc1~186 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8df81e17f81ba0542f6dbb7636db64fa56c12d8a;p=platform%2Fkernel%2Fu-boot.git image-fit: Don't display an error in fit_set_timestamp() This function returns an error code and its caller may be able to fix the error. For example fit_handle_file() expands the device tree to fit if there is a lack of space. In this case the caller does not want an error displayed. It is confusing, since it suggests that something is wrong, when it fact everything is fine. Drop the error. Signed-off-by: Simon Glass --- diff --git a/common/image-fit.c b/common/image-fit.c index 25f8a11..c86b7c6 100644 --- a/common/image-fit.c +++ b/common/image-fit.c @@ -886,9 +886,9 @@ int fit_set_timestamp(void *fit, int noffset, time_t timestamp) ret = fdt_setprop(fit, noffset, FIT_TIMESTAMP_PROP, &t, sizeof(uint32_t)); if (ret) { - printf("Can't set '%s' property for '%s' node (%s)\n", - FIT_TIMESTAMP_PROP, fit_get_name(fit, noffset, NULL), - fdt_strerror(ret)); + debug("Can't set '%s' property for '%s' node (%s)\n", + FIT_TIMESTAMP_PROP, fit_get_name(fit, noffset, NULL), + fdt_strerror(ret)); return ret == -FDT_ERR_NOSPACE ? -ENOSPC : -1; }