From: Vasily Gorbik <gor@linux.ibm.com>
Date: Mon, 19 Aug 2019 14:29:01 +0000 (+0200)
Subject: s390/pci: avoid using strncmp with hardcoded length
X-Git-Tag: v5.15~5531^2~17
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8dec6bd4ef327f48eb790a48cba0e833109d4e41;p=platform%2Fkernel%2Flinux-starfive.git

s390/pci: avoid using strncmp with hardcoded length

Command line option values passed to __setup callbacks are always
null-terminated and "s390_iommu=" may only accept "strict" as value.
So replace strncmp with strcmp.

While at it also make s390_iommu_setup return 1, which means this
command line option is handled by this callback.

Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
---

diff --git a/arch/s390/pci/pci_dma.c b/arch/s390/pci/pci_dma.c
index 9e52d15..fb2c7db 100644
--- a/arch/s390/pci/pci_dma.c
+++ b/arch/s390/pci/pci_dma.c
@@ -674,9 +674,9 @@ EXPORT_SYMBOL_GPL(s390_pci_dma_ops);
 
 static int __init s390_iommu_setup(char *str)
 {
-	if (!strncmp(str, "strict", 6))
+	if (!strcmp(str, "strict"))
 		s390_iommu_strict = 1;
-	return 0;
+	return 1;
 }
 
 __setup("s390_iommu=", s390_iommu_setup);