From: Wei Yongjun Date: Tue, 17 Jan 2017 15:55:32 +0000 (+0000) Subject: pinctrl/amd: Drop pinctrl_unregister for devm_ registered device X-Git-Tag: v5.15~11858^2~46 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8dca4a41f1ad65043a78c2338d9725f859c8d2c3;p=platform%2Fkernel%2Flinux-starfive.git pinctrl/amd: Drop pinctrl_unregister for devm_ registered device It's not necessary to unregister pin controller device registered with devm_pinctrl_register() and using pinctrl_unregister() leads to a double free. Fixes: 3bfd44306c65 ("pinctrl: amd: Add support for additional GPIO") Signed-off-by: Wei Yongjun Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c index 1ee107f..6b75bd2 100644 --- a/drivers/pinctrl/pinctrl-amd.c +++ b/drivers/pinctrl/pinctrl-amd.c @@ -836,7 +836,6 @@ static int amd_gpio_remove(struct platform_device *pdev) gpio_dev = platform_get_drvdata(pdev); gpiochip_remove(&gpio_dev->gc); - pinctrl_unregister(gpio_dev->pctrl); return 0; }