From: Arnaud Renevier Date: Tue, 24 Feb 2015 00:33:43 +0000 (-0800) Subject: Remove SendOrientationChangeEventIfNeeded X-Git-Tag: submit/tizen/20201118.160233~1165 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8d703dd3522bd18d7bf6908977808373d077c869;p=platform%2Fframework%2Fweb%2Fchromium-efl.git Remove SendOrientationChangeEventIfNeeded SendOrientationChangeEventIfNeeded method is not used anymore. It has been replaced by SetOrientation. This patch removes the unneeded method. Reviewed by: Antonio Gomes, Piotr Tworek Change-Id: I9604cc01dc0f61d3a2489b8339ce06722daf482c Signed-off-by: Arnaud Renevier --- diff --git a/tizen_src/impl/eweb_view.cc b/tizen_src/impl/eweb_view.cc index d98554c..41dd834 100644 --- a/tizen_src/impl/eweb_view.cc +++ b/tizen_src/impl/eweb_view.cc @@ -629,29 +629,6 @@ void EWebView::ExecuteEditCommand(const char* command, const char* value) { } } -void EWebView::SendOrientationChangeEventIfNeeded(int orientation) { - RenderViewHostImpl* rvhi = static_cast( - web_contents_->GetRenderViewHost()); -#warning "[M37] Fix screen orientation" -#if 0 - //send new orientation value to RenderView Host to pass to renderer - if(rvhi && rvhi->GetOrientation() != orientation) { - switch(orientation) { - case -90: - case 0: - case 90: - case 180: - rvhi->SendOrientationChangeEvent(orientation); - break; - - default: - NOTREACHED(); - break; - } - } -#endif -} - void EWebView::SetOrientation(int orientation) { // For backward compatibility, a value in range of [0, 360] is used // instead of [-90, 180] because the class gfx::Display, containing diff --git a/tizen_src/impl/eweb_view.h b/tizen_src/impl/eweb_view.h index 60bd950..e387a7c 100644 --- a/tizen_src/impl/eweb_view.h +++ b/tizen_src/impl/eweb_view.h @@ -278,7 +278,6 @@ class EWebView { void SetTextZoomFactor(double text_zoom_factor); void ExecuteEditCommand(const char* command, const char* value); void SetOrientation(int orientation); - void SendOrientationChangeEventIfNeeded(int orientation); void SetOrientationLockCallback(tizen_webview::Orientation_Lock_Cb func, void* data); bool TouchEventsEnabled() const; void SetTouchEventsEnabled(bool enabled); diff --git a/tizen_src/impl/tizen_webview/public/tw_webview.cc b/tizen_src/impl/tizen_webview/public/tw_webview.cc index 8ae00bf..55ff43c 100644 --- a/tizen_src/impl/tizen_webview/public/tw_webview.cc +++ b/tizen_src/impl/tizen_webview/public/tw_webview.cc @@ -303,10 +303,6 @@ void WebView::GetScrollSize(int* w, int* h) { return impl_->GetScrollSize(w, h); } -void WebView::SendOrientationChangeEventIfNeeded(int orientation) { - return impl_->SendOrientationChangeEventIfNeeded(orientation); -} - void WebView::SetOrientation(int orientation) { return impl_->SetOrientation(orientation); } diff --git a/tizen_src/impl/tizen_webview/public/tw_webview.h b/tizen_src/impl/tizen_webview/public/tw_webview.h index 19e360d..0fe5a4d 100644 --- a/tizen_src/impl/tizen_webview/public/tw_webview.h +++ b/tizen_src/impl/tizen_webview/public/tw_webview.h @@ -134,7 +134,6 @@ class WebView { void SetScroll(int x, int y); // TODO: rename to ScrollTo (x,y) x,y is left top (see GetScrollSize) void GetScrollSize(int* w, int* h); // TODO: rename to GetPossibleScrollSize // > View Orientation - void SendOrientationChangeEventIfNeeded(int orientation); void SetOrientation(int orientation); void SetOrientationLockCallback(Orientation_Lock_Cb func, void* data); // > View mode