From: Alexandre Belloni Date: Mon, 12 Feb 2018 22:47:53 +0000 (+0100) Subject: rtc: stk17ta8: fix possible race condition X-Git-Tag: v4.19~1240^2~84 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8d3e6b55cedaeadd1216d4b548f346c169099f1f;p=platform%2Fkernel%2Flinux-rpi.git rtc: stk17ta8: fix possible race condition The probe function is not allowed to fail after registering the RTC. Call rtc_register_device() at the end. Signed-off-by: Alexandre Belloni --- diff --git a/drivers/rtc/rtc-stk17ta8.c b/drivers/rtc/rtc-stk17ta8.c index f936acc..1d6febb 100644 --- a/drivers/rtc/rtc-stk17ta8.c +++ b/drivers/rtc/rtc-stk17ta8.c @@ -334,11 +334,11 @@ static int stk17ta8_rtc_probe(struct platform_device *pdev) pdata->rtc->ops = &stk17ta8_rtc_ops; - ret = rtc_register_device(pdata->rtc); + ret = sysfs_create_bin_file(&pdev->dev.kobj, &stk17ta8_nvram_attr); if (ret) return ret; - ret = sysfs_create_bin_file(&pdev->dev.kobj, &stk17ta8_nvram_attr); + ret = rtc_register_device(pdata->rtc); return ret; }