From: Florian Ragwitz <rafl@debian.org>
Date: Thu, 7 Jul 2011 13:44:45 +0000 (+0200)
Subject: Make sure there's no superfluous Maintainer.pl entries
X-Git-Tag: accepted/trunk/20130322.191538~3406
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8ceba1a470d4a87a27f40e4a0187b7d28c6d4912;p=platform%2Fupstream%2Fperl.git

Make sure there's no superfluous Maintainer.pl entries
---

diff --git a/Porting/Maintainers.pm b/Porting/Maintainers.pm
index f1016b4..c98413a 100644
--- a/Porting/Maintainers.pm
+++ b/Porting/Maintainers.pm
@@ -314,8 +314,9 @@ sub show_results {
 			    : sub { /\.(?:[chty]|p[lm]|xs)\z/msx },
 			@Files
 		    );
-		} else { 
+		} else {
 		    duplicated_maintainers();
+		    superfluous_maintainers();
 		}
     } elsif (@Files) {
 	my $ModuleByFile = files_to_modules(@Files);
@@ -391,6 +392,23 @@ sub missing_maintainers {
     find sub { warn_maintainer($File::Find::name) if $check->() }, @dir if @dir;
 }
 
+sub superfluous_maintainers {
+    maintainers_files();
+    for my $f (keys %files) {
+	if ($TapOutput) {
+	    if ($MANIFEST{$f}) {
+		print "ok ".++$TestCounter." - Maintained file $f appears in MANIFEST\n";
+	    } else {
+		print "not ok ".++$TestCounter." - File $f has has a maintainer but is not in MANIFEST\n";
+	    }
+	} else {
+	    if (!$MANIFEST{$f}) {
+		warn "File $f has has a maintainer but is not in MANIFEST\n";
+	    }
+	}
+    }
+}
+
 sub finish_tap_output {
     print "1..".$TestCounter."\n"; 
 }