From: Uwe Kleine-König Date: Tue, 5 Jul 2022 20:51:42 +0000 (+0200) Subject: crypto: omap-des - Drop if with an always false condition X-Git-Tag: v6.6.17~6939^2~28 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8ce715e711659322a6e05cad154aa1355bb2e14f;p=platform%2Fkernel%2Flinux-rpi.git crypto: omap-des - Drop if with an always false condition The remove callback is only called after probe completed successfully. In this case platform_set_drvdata() was called with a non-NULL argument and so dd is never NULL. This is a preparation for making platform remove callbacks return void. While touching this driver remove an assignment without effect. Signed-off-by: Uwe Kleine-König Signed-off-by: Herbert Xu --- diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c index 538aff8..f783769 100644 --- a/drivers/crypto/omap-des.c +++ b/drivers/crypto/omap-des.c @@ -1091,9 +1091,6 @@ static int omap_des_remove(struct platform_device *pdev) struct omap_des_dev *dd = platform_get_drvdata(pdev); int i, j; - if (!dd) - return -ENODEV; - spin_lock_bh(&list_lock); list_del(&dd->list); spin_unlock_bh(&list_lock); @@ -1106,7 +1103,6 @@ static int omap_des_remove(struct platform_device *pdev) tasklet_kill(&dd->done_task); omap_des_dma_cleanup(dd); pm_runtime_disable(dd->dev); - dd = NULL; return 0; }