From: Eunhye Choi Date: Wed, 23 Feb 2022 07:49:35 +0000 (+0900) Subject: Fix Coverity Issue X-Git-Tag: accepted/tizen/unified/20220223.132506^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8c42157cc93445937af5aa01baa7ad33cea1306b;p=platform%2Fcore%2Fapi%2Fmediademuxer.git Fix Coverity Issue [Version] 0.1.38 [Issue Type] Fix svace issue Change-Id: I59c7f5463e8e9f4b9d88e7a521cf16ddc2017123 --- diff --git a/packaging/capi-mediademuxer.spec b/packaging/capi-mediademuxer.spec index c5b4be7..b49aa52 100644 --- a/packaging/capi-mediademuxer.spec +++ b/packaging/capi-mediademuxer.spec @@ -1,6 +1,6 @@ Name: capi-mediademuxer Summary: A Media Demuxer library in Tizen Native API -Version: 0.1.37 +Version: 0.1.38 Release: 1 Group: Multimedia/API License: Apache-2.0 diff --git a/src/port_gst/mediademuxer_port_gst.c b/src/port_gst/mediademuxer_port_gst.c index d53637f..d3132d4 100644 --- a/src/port_gst/mediademuxer_port_gst.c +++ b/src/port_gst/mediademuxer_port_gst.c @@ -500,7 +500,10 @@ static int __gst_add_track_info(GstPad *pad, GstCaps *caps, track **head, gst_caps_unref(outcaps); temp->need_codec_data = FALSE; } else if (strstr(temp->caps_string, "mpeg")) { - gst_element_link(parse_element, temp->appsink); + if (!gst_element_link(parse_element, temp->appsink)) { + MD_E("failed to link parse element to appsink"); + goto ERROR; + } } else { MEDIADEMUXER_LINK_PAD(queue_src_pad, apppad, ERROR); } @@ -597,7 +600,10 @@ static int __gst_add_track_info(GstPad *pad, GstCaps *caps, track **head, MEDIADEMUXER_SYNC_STATE_WITH_PARENT(parse_element, ERROR); /* Link src pad with appSink element */ - gst_element_link(parse_element, temp->appsink); + if (!gst_element_link(parse_element, temp->appsink)) { + MD_E("failed to link parse element to appsink"); + goto ERROR; + } } else { MEDIADEMUXER_LINK_PAD(queue_src_pad, apppad, ERROR); } @@ -1943,4 +1949,4 @@ static int __gst_eos_callback(int track_num, void* user_data) MD_E("EOS received, but callback is not set!!!"); return MD_ERROR_NONE; } -//LCOV_EXCL_STOP \ No newline at end of file +//LCOV_EXCL_STOP