From: Matthew Waters <matthew@centricular.com>
Date: Thu, 21 Oct 2021 09:32:05 +0000 (+1100)
Subject: rtpbin: fix leak of pad when a fec encoder and aux sender a created
X-Git-Tag: 1.19.3~93
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8c35850f2388473497f531a412939df2405ed325;p=platform%2Fupstream%2Fgstreamer.git

rtpbin: fix leak of pad when a fec encoder and aux sender a created

The ghost sink pad retrieved by rtpbin from the aux sender was not freed
when there was a previous element (fec encoder) in the chain.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1222>
---

diff --git a/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpbin.c b/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpbin.c
index 39596cc..01e8dff 100644
--- a/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpbin.c
+++ b/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpbin.c
@@ -4842,6 +4842,7 @@ create_send_rtp (GstRtpBin * rtpbin, GstPadTemplate * templ, const gchar * name)
       if (ret != GST_PAD_LINK_OK) {
         goto aux_link_failed;
       }
+      gst_object_unref (sinkpad);
     }
     prev = aux;
   } else {