From: Dan Carpenter Date: Wed, 9 Dec 2015 10:24:06 +0000 (+0300) Subject: nvme: precedence bug in nvme_pr_clear() X-Git-Tag: v4.5-rc1~26^2~40 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8c0b39155048d5a24f25c6c60aa83729927b04cd;p=platform%2Fkernel%2Flinux-exynos.git nvme: precedence bug in nvme_pr_clear() The "|" operator has higher precedence than "?:" so this didn't work as intended. I had previously fixed this bug, but it we copied the older unfixed version when we moved the function between files. Fixes: 1673f1f08c88 ('nvme: move block_device_operations and ns/ctrl freeing to common code') Signed-off-by: Dan Carpenter Signed-off-by: Jens Axboe --- diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 47ebfb8..64891eb 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -671,7 +671,7 @@ static int nvme_pr_preempt(struct block_device *bdev, u64 old, u64 new, static int nvme_pr_clear(struct block_device *bdev, u64 key) { - u32 cdw10 = 1 | key ? 1 << 3 : 0; + u32 cdw10 = 1 | (key ? 1 << 3 : 0); return nvme_pr_command(bdev, cdw10, key, 0, nvme_cmd_resv_register); }