From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 17 Oct 2011 17:01:47 +0000 (+0000)
Subject: pptp: fix skb leak in pptp_xmit()
X-Git-Tag: v3.1~9^2~6
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8bae8bd6cb24eecad9fda3e125d36ab9c67d3fd7;p=platform%2Fkernel%2Flinux-stable.git

pptp: fix skb leak in pptp_xmit()

In case we cant transmit skb, we must free it

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Dmitry Kozlov <xeb@mail.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/pptp.c b/drivers/net/pptp.c
index eae542a..9c0403d 100644
--- a/drivers/net/pptp.c
+++ b/drivers/net/pptp.c
@@ -285,8 +285,10 @@ static int pptp_xmit(struct ppp_channel *chan, struct sk_buff *skb)
 	ip_send_check(iph);
 
 	ip_local_out(skb);
+	return 1;
 
 tx_error:
+	kfree_skb(skb);
 	return 1;
 }