From: Dafna Hirschfeld Date: Wed, 22 Jan 2020 09:52:51 +0000 (+0100) Subject: media: vimc: streamer: if kthread_stop fails, ignore the error X-Git-Tag: v5.15~4247^2~190 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8b9f91751b6ff19449526d63a0675177ce10f9c7;p=platform%2Fkernel%2Flinux-starfive.git media: vimc: streamer: if kthread_stop fails, ignore the error Ignore errors returned from kthread_stop since the vimc subdevices should still be notified that streaming stopped so they can release the memory for the streaming, and also kthread should be set to NULL. kthread_stop can return -EINTR in case the thread did not yet run. This can happen if userspace calls streamon and streamoff right after. Signed-off-by: Dafna Hirschfeld Acked-by: Helen Koike Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/vimc/vimc-streamer.c b/drivers/media/platform/vimc/vimc-streamer.c index 43e494d..65feb3c 100644 --- a/drivers/media/platform/vimc/vimc-streamer.c +++ b/drivers/media/platform/vimc/vimc-streamer.c @@ -220,8 +220,14 @@ int vimc_streamer_s_stream(struct vimc_stream *stream, return 0; ret = kthread_stop(stream->kthread); + /* + * kthread_stop returns -EINTR in cases when streamon was + * immediately followed by streamoff, and the thread didn't had + * a chance to run. Ignore errors to stop the stream in the + * pipeline. + */ if (ret) - return ret; + dev_dbg(ved->dev, "kthread_stop returned '%d'\n", ret); stream->kthread = NULL;