From: Philip Withnall <philip.withnall@collabora.co.uk>
Date: Wed, 23 Jun 2010 10:50:05 +0000 (+0100)
Subject: Note about a Vala bug when chaining constructors which affects us
X-Git-Tag: FOLKS_0_1_9~64^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8b63168531a8346e19e4ffa8cd3abe8f110efcbb;p=platform%2Fupstream%2Ffolks.git

Note about a Vala bug when chaining constructors which affects us
---

diff --git a/backends/telepathy/tpf-persona.vala b/backends/telepathy/tpf-persona.vala
index 5d994db..9f82e52 100644
--- a/backends/telepathy/tpf-persona.vala
+++ b/backends/telepathy/tpf-persona.vala
@@ -97,6 +97,9 @@ public class Tpf.Persona : Folks.Persona, Alias, Avatar, Folks.Capabilities,
 
   public Persona (Contact contact, PersonaStore store) throws Tp.Error
     {
+      /* FIXME: There is the possibility of a crash in the error condition below
+       * due to bgo#604299, where the C self variable isn't initialised until we
+       * chain up to the Object constructor, below. */
       var uid = contact.get_identifier ();
       if (uid == null || uid == "")
         throw new Tp.Error.INVALID_ARGUMENT ("contact has an invalid UID");