From: Krzysztof Kozlowski Date: Wed, 28 Jun 2017 14:56:17 +0000 (+0200) Subject: PM / Domains: Handle safely genpd_syscore_switch() call on non-genpd device X-Git-Tag: v4.14-rc1~417^2^3~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8b55e55ee44356d68f4a7ee4b11f9cbb1f5958cc;p=platform%2Fkernel%2Flinux-rpi.git PM / Domains: Handle safely genpd_syscore_switch() call on non-genpd device genpd_syscore_switch() had two problems: 1. It silently assumed that device, it is being called for, belongs to generic power domain and used container_of() on its power domain pointer. Such assumption might not be true always. 2. It iterated over list of generic power domains without holding gpd_list_lock mutex thus list could have been modified at the same time. Usage of genpd_lookup_dev() solves both problems as it is safe a call for non-generic power domains and uses mutex when iterating. Reported-by: Ulf Hansson Signed-off-by: Krzysztof Kozlowski Acked-by: Ulf Hansson Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index bbbb1d7..b8d7907 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -1148,8 +1148,8 @@ static void genpd_syscore_switch(struct device *dev, bool suspend) { struct generic_pm_domain *genpd; - genpd = dev_to_genpd(dev); - if (!pm_genpd_present(genpd)) + genpd = genpd_lookup_dev(dev); + if (!genpd) return; if (suspend) {