From: SangJin Kim <sangjin3.kim@samsung.com>
Date: Wed, 21 Dec 2016 10:32:08 +0000 (+0900)
Subject: Fix SVACE issue.
X-Git-Tag: accepted/tizen/3.0/ivi/20161226.024555^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8b42e21eaefd8589d4306f0ed26e57e387a56588;p=sdk%2Ftarget%2Fsdbd.git

Fix SVACE issue.

Change-Id: I640624dc49117b8eca6034b41ae33b2e52b8eb8c
Signed-off-by: SangJin Kim <sangjin3.kim@samsung.com>
---

diff --git a/src/default_plugin_appcmd.c b/src/default_plugin_appcmd.c
index 4bc158e..07a41d1 100644
--- a/src/default_plugin_appcmd.c
+++ b/src/default_plugin_appcmd.c
@@ -332,11 +332,15 @@ static void appcmd_receiver_packagelist(int fd_in, int fd_out)
     char out_buf[4096] = {0,};
     int out_ptr = 0;
     int r;
+    char* sub1;
+    char* sub2;
 
     snprintf(out_buf, sizeof(out_buf), "\n%s", MESSAGE_PREFIX_APPCMD_RETURN);
     out_ptr = strlen(out_buf);
 
     for(;;) {
+        sub1 = NULL;
+        sub2 = NULL;
         memset(buf, 0, sizeof(buf));
         r = read_line(fd_in, buf, sizeof(buf));
         if (r == 0) {
@@ -350,17 +354,22 @@ static void appcmd_receiver_packagelist(int fd_in, int fd_out)
         }
 
         D("pkgcmd output : %s\n", buf);
-        char* sub1 = NULL;
-        char* sub2 = NULL;
         sub1 = strstr(buf, "pkgid [");
-        if (sub1 != NULL) {
-            sub1 = strstr(sub1, "[")+1;
-            sub2 = strstr(sub1, "]");
-            sub2[0] = '\0';
-
-            snprintf(out_buf+out_ptr, sizeof(out_buf)-out_ptr, ":%s", sub1);
-            out_ptr += strlen(sub1)+1;
+        if (sub1 == NULL) {
+            continue;
+        }
+        sub1 = strstr(sub1, "[")+1;
+        if (sub1 == NULL) {
+            continue;
         }
+        sub2 = strstr(sub1, "]");
+        if (sub2 == NULL) {
+            continue;
+        }
+        sub2[0] = '\0';
+
+        snprintf(out_buf+out_ptr, sizeof(out_buf)-out_ptr, ":%s", sub1);
+        out_ptr += strlen(sub1)+1;
     }
 
     snprintf(out_buf+out_ptr, sizeof(out_buf)-out_ptr, "\n");