From: Santiago Fernandez Madero Date: Tue, 5 May 2020 01:34:15 +0000 (-0700) Subject: Reduce usage of Win7 and Win8 queues, move to CI and add CI runs in Win arm/arm64... X-Git-Tag: submit/tizen/20210909.063632~8196 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8b386434b134df5011e42a604d836b7ceae8b2a0;p=platform%2Fupstream%2Fdotnet%2Fruntime.git Reduce usage of Win7 and Win8 queues, move to CI and add CI runs in Win arm/arm64 (#35690) * Reduce usage of Win7 and Win8 queues, move to CI and add CI runs in Win arm/arm62 * Disable tests blocking clean rolling build * Disable more failing tests * Disable more failing tests --- diff --git a/eng/pipelines/libraries/helix-queues-setup.yml b/eng/pipelines/libraries/helix-queues-setup.yml index 28a6aa6..c221d8b 100644 --- a/eng/pipelines/libraries/helix-queues-setup.yml +++ b/eng/pipelines/libraries/helix-queues-setup.yml @@ -88,15 +88,17 @@ jobs: # netcoreapp - ${{ if notIn(parameters.jobParameters.framework, 'allConfigurations', 'net472') }}: - ${{ if eq(parameters.jobParameters.isFullMatrix, true) }}: - - Windows.7.Amd64.Open + # Bring back once: https://github.com/dotnet/runtime/issues/35689 is fixed + # - Windows.7.Amd64.Open - Windows.81.Amd64.Open - Windows.10.Amd64.ServerRS5.Open - Windows.10.Amd64.Server19H1.Open - ${{ if ne(parameters.jobParameters.runtimeFlavor, 'mono') }}: - (Windows.Nano.1809.Amd64.Open)windows.10.amd64.serverrs5.open@mcr.microsoft.com/dotnet-buildtools/prereqs:nanoserver-1809-helix-amd64-08e8e40-20200107182504 - ${{ if eq(parameters.jobParameters.isFullMatrix, false) }}: - - Windows.7.Amd64.Open - - Windows.81.Amd64.Open + # Bring back once: https://github.com/dotnet/runtime/issues/35689 is fixed + # - Windows.7.Amd64.Open + # - Windows.81.Amd64.Open - Windows.10.Amd64.Server19H1.ES.Open - ${{ if ne(parameters.jobParameters.runtimeFlavor, 'mono') }}: - (Windows.Nano.1809.Amd64.Open)windows.10.amd64.serverrs5.open@mcr.microsoft.com/dotnet-buildtools/prereqs:nanoserver-1809-helix-amd64-08e8e40-20200107182504 @@ -115,19 +117,29 @@ jobs: - ${{ if notIn(parameters.jobParameters.framework, 'allConfigurations', 'net472') }}: - ${{ if eq(parameters.jobParameters.isFullMatrix, true) }}: - Windows.7.Amd64.Open - - Windows.81.Amd64.Open + # Bring back once: https://github.com/dotnet/runtime/issues/35689 is fixed + # - Windows.81.Amd64.Open - Windows.10.Amd64.ServerRS5.Open - Windows.10.Amd64.Server19H1.Open - ${{ if eq(parameters.jobParameters.isFullMatrix, false) }}: - ${{ if eq(parameters.jobParameters.buildConfig, 'Release') }}: - - Windows.7.Amd64.Open - - Windows.81.Amd64.Open - Windows.10.Amd64.Server19H1.ES.Open - ${{ if eq(parameters.jobParameters.buildConfig, 'Debug') }}: + # Bring back once: https://github.com/dotnet/runtime/issues/35689 is fixed + # - Windows.7.Amd64.Open + # - Windows.81.Amd64.Open - Windows.10.Amd64.Server19H1.Open # NET472 - ${{ if eq(parameters.jobParameters.framework, 'net472') }}: - Windows.10.Amd64.Client19H1.Open + # Windows_NT arm + - ${{ if eq(parameters.platform, 'Windows_NT_arm') }}: + - Windows.10.Arm64v8.Open + + # Windows_NT arm64 + - ${{ if eq(parameters.platform, 'Windows_NT_arm64') }}: + - Windows.10.Arm64.Open + ${{ insert }}: ${{ parameters.jobParameters }} diff --git a/eng/pipelines/runtime.yml b/eng/pipelines/runtime.yml index 40f22e1..229c705 100644 --- a/eng/pipelines/runtime.yml +++ b/eng/pipelines/runtime.yml @@ -780,6 +780,9 @@ jobs: buildConfig: Release platforms: - Windows_NT_x86 + - ${{ if eq(variables['isFullMatrix'], true) }}: + - Windows_NT_arm + - Windows_NT_arm64 helixQueuesTemplate: /eng/pipelines/libraries/helix-queues-setup.yml jobParameters: isOfficialBuild: false diff --git a/src/libraries/Microsoft.Extensions.DependencyInjection/tests/DependencyInjectionEventSourceTests.cs b/src/libraries/Microsoft.Extensions.DependencyInjection/tests/DependencyInjectionEventSourceTests.cs index 99b8a6a..ddbde7b 100644 --- a/src/libraries/Microsoft.Extensions.DependencyInjection/tests/DependencyInjectionEventSourceTests.cs +++ b/src/libraries/Microsoft.Extensions.DependencyInjection/tests/DependencyInjectionEventSourceTests.cs @@ -193,6 +193,7 @@ namespace Microsoft.Extensions.DependencyInjection } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/35753", TestPlatforms.Windows)] public void EmitsDynamicMethodBuiltEvent() { // Arrange diff --git a/src/libraries/System.Drawing.Common/tests/BitmapTests.cs b/src/libraries/System.Drawing.Common/tests/BitmapTests.cs index e45488a..997b206 100644 --- a/src/libraries/System.Drawing.Common/tests/BitmapTests.cs +++ b/src/libraries/System.Drawing.Common/tests/BitmapTests.cs @@ -815,6 +815,12 @@ namespace System.Drawing.Tests throw new SkipTestException("GDI+ 1.1 is not supported"); } + if (PlatformDetection.IsArmOrArm64Process) + { + // https://github.com/dotnet/runtime/issues/28859 + throw new SkipTestException("Arm precision"); + } + string output = GetTestFilePath() + ".png"; using Stream wmfStream = File.OpenRead(Helpers.GetTestBitmapPath("gdiwmfboundariesbug.wmf")); using Image bitmapFromWmf = Bitmap.FromStream(wmfStream); diff --git a/src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializerStressTests.cs b/src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializerStressTests.cs index a200296..0daf0c9 100644 --- a/src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializerStressTests.cs +++ b/src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializerStressTests.cs @@ -11,6 +11,7 @@ using Xunit; public static partial class DataContractSerializerTests { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/34962", TestRuntimes.Mono)] public static void DCS_MyPersonSurrogate_Stress() { // This test is to verify a bug fix made in ObjectToIdCache.cs. diff --git a/src/libraries/System.Runtime/tests/System/ArgIteratorTests.cs b/src/libraries/System.Runtime/tests/System/ArgIteratorTests.cs index 1ad30e5..5508c13 100644 --- a/src/libraries/System.Runtime/tests/System/ArgIteratorTests.cs +++ b/src/libraries/System.Runtime/tests/System/ArgIteratorTests.cs @@ -2,6 +2,7 @@ // The .NET Foundation licenses this file to you under the MIT license. // See the LICENSE file in the project root for more information. +using Microsoft.DotNet.XUnitExtensions; using System.Globalization; using System.Reflection; using Xunit; @@ -90,6 +91,12 @@ namespace System.Tests [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsArgIteratorNotSupported))] public static unsafe void ArgIterator_Throws_PlatformNotSupportedException() { + if (PlatformDetection.IsWindows && PlatformDetection.IsArmProcess) + { + // Active Issue: https://github.com/dotnet/runtime/issues/35754 + throw new SkipTestException("ArgIterator doesn't throw not supported in ArmProcess"); + } + Assert.Throws(() => new ArgIterator(new RuntimeArgumentHandle())); Assert.Throws(() => { fixed (void* p = "test") diff --git a/src/libraries/System.Runtime/tests/System/Runtime/MemoryFailPointTests.cs b/src/libraries/System.Runtime/tests/System/Runtime/MemoryFailPointTests.cs index 9c17bc6..6f82da1 100644 --- a/src/libraries/System.Runtime/tests/System/Runtime/MemoryFailPointTests.cs +++ b/src/libraries/System.Runtime/tests/System/Runtime/MemoryFailPointTests.cs @@ -2,6 +2,7 @@ // The .NET Foundation licenses this file to you under the MIT license. // See the LICENSE file in the project root for more information. +using Microsoft.DotNet.XUnitExtensions; using Xunit; namespace System.Runtime.Tests @@ -26,10 +27,15 @@ namespace System.Runtime.Tests AssertExtensions.Throws("sizeInMegabytes", () => new MemoryFailPoint(sizeInMegabytes)); } - [Fact] + [ConditionalFact] [PlatformSpecific(TestPlatforms.Windows)] //https://github.com/dotnet/runtime/issues/6879 public void Ctor_LargeSizeInMegabytes_ThrowsInsufficientMemoryException() { + if (PlatformDetection.IsArmProcess) + { + throw new SkipTestException("[ActiveIssue: https://github.com/dotnet/runtime/issues/35805]"); + } + Assert.Throws(() => new MemoryFailPoint(int.MaxValue)); } }