From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Date: Thu, 30 May 2013 11:55:34 +0000 (+0800)
Subject: ALSA: sis7019: fix error return code in sis_chip_create()
X-Git-Tag: v3.10-rc5~15^2~10
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8b1dacb6ae15c94d50642a474e5af8981555253b;p=platform%2Fkernel%2Flinux-stable.git

ALSA: sis7019: fix error return code in sis_chip_create()

Fix to return a negative error code in the pci_set_dma_mask() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/pci/sis7019.c b/sound/pci/sis7019.c
index d59abe1..748e82d 100644
--- a/sound/pci/sis7019.c
+++ b/sound/pci/sis7019.c
@@ -1341,7 +1341,8 @@ static int sis_chip_create(struct snd_card *card,
 	if (rc)
 		goto error_out;
 
-	if (pci_set_dma_mask(pci, DMA_BIT_MASK(30)) < 0) {
+	rc = pci_set_dma_mask(pci, DMA_BIT_MASK(30));
+	if (rc < 0) {
 		dev_err(&pci->dev, "architecture does not support 30-bit PCI busmaster DMA");
 		goto error_out_enabled;
 	}