From: Alexander Holler Date: Fri, 20 Apr 2012 22:11:07 +0000 (+0200) Subject: video/smscufx: fix line counting in fb_write X-Git-Tag: v3.4.9~43 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8b0331a46c6aa9f853e1208b0ce137c4d1d4fc1a;p=platform%2Fkernel%2Flinux-stable.git video/smscufx: fix line counting in fb_write commit 2fe2d9f47cfe1a3e66e7d087368b3d7155b04c15 upstream. Line 0 and 1 were both written to line 0 (on the display) and all subsequent lines had an offset of -1. The result was that the last line on the display was never overwritten by writes to /dev/fbN. The origin of this bug seems to have been udlfb. Signed-off-by: Alexander Holler Signed-off-by: Florian Tobias Schandinat Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/video/smscufx.c b/drivers/video/smscufx.c index ccbfef5..1e1e2d2 100644 --- a/drivers/video/smscufx.c +++ b/drivers/video/smscufx.c @@ -904,7 +904,7 @@ static ssize_t ufx_ops_write(struct fb_info *info, const char __user *buf, result = fb_sys_write(info, buf, count, ppos); if (result > 0) { - int start = max((int)(offset / info->fix.line_length) - 1, 0); + int start = max((int)(offset / info->fix.line_length), 0); int lines = min((u32)((result / info->fix.line_length) + 1), (u32)info->var.yres);