From: Niklas Söderlund Date: Wed, 24 May 2017 00:15:39 +0000 (-0300) Subject: [media] rcar-vin: add missing error check to propagate error X-Git-Tag: v4.13-rc4~5^2~296 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8afb72eda5f3f6f032a3b95b9ea59db2e1e2fcfc;p=platform%2Fkernel%2Flinux-exynos.git [media] rcar-vin: add missing error check to propagate error The return value of __rvin_try_format_source is not checked, add a check and propagate the error. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c index be6f41b..846bcd8 100644 --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c @@ -208,6 +208,7 @@ static int __rvin_try_format(struct rvin_dev *vin, { const struct rvin_video_format *info; u32 rwidth, rheight, walign; + int ret; /* Requested */ rwidth = pix->width; @@ -235,7 +236,9 @@ static int __rvin_try_format(struct rvin_dev *vin, pix->sizeimage = 0; /* Limit to source capabilities */ - __rvin_try_format_source(vin, which, pix, source); + ret = __rvin_try_format_source(vin, which, pix, source); + if (ret) + return ret; switch (pix->field) { case V4L2_FIELD_TOP: