From: Sungtaek Hong <sth253.hong@samsung.com>
Date: Wed, 7 Dec 2016 09:53:26 +0000 (+0900)
Subject: efreet_desktop: fix potential error in efreet_desktop_cache_create
X-Git-Tag: accepted/tizen/common/20170102.152350~107
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8ae04203cf156c7f1673cd7f5739f4aca70ad5cd;p=platform%2Fupstream%2Fefl.git

efreet_desktop: fix potential error in efreet_desktop_cache_create

 - old_file_ids is freed but not set as NULL.
   If it goes to error code, old_file_ids will be freed again.

   Differential Revision: https://phab.enlightenment.org/D4467

Change-Id: I22b24dc1480e8dce17e2588febfc2fd885970475
Signed-off-by: Sungtaek Hong <sth253.hong@samsung.com>
---

diff --git a/src/bin/efreet/efreet_desktop_cache_create.c b/src/bin/efreet/efreet_desktop_cache_create.c
index 849c491..18955e0 100644
--- a/src/bin/efreet/efreet_desktop_cache_create.c
+++ b/src/bin/efreet/efreet_desktop_cache_create.c
@@ -502,6 +502,7 @@ main(int argc, char **argv)
     {
         eina_hash_free(old_file_ids->hash);
         free(old_file_ids);
+        old_file_ids = NULL;
     }
 
     eina_hash_free(file_ids);