From: Jian Shen Date: Mon, 15 Apr 2019 13:48:38 +0000 (+0800) Subject: net: hns3: fix sparse: warning when calling hclge_set_vlan_filter_hw() X-Git-Tag: v5.4-rc1~1056^2~171^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8a9a654b5b5233e7459abcc5f65c53df14b33f67;p=platform%2Fkernel%2Flinux-rpi.git net: hns3: fix sparse: warning when calling hclge_set_vlan_filter_hw() The input parameter "proto" in function hclge_set_vlan_filter_hw() is asked to be __be16, but got u16 when calling it in function hclge_update_port_base_vlan_cfg(). This patch fixes it by converting it with htons(). Reported-by: kbuild test robot Fixes: 21e043cd8124 ("net: hns3: fix set port based VLAN for PF") Signed-off-by: Jian Shen Signed-off-by: Huazhong Tan Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c index d2fb548e..7dba3b4 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c @@ -6964,7 +6964,8 @@ int hclge_update_port_base_vlan_cfg(struct hclge_vport *vport, u16 state, if (state == HNAE3_PORT_BASE_VLAN_MODIFY) { /* add new VLAN tag */ - ret = hclge_set_vlan_filter_hw(hdev, vlan_info->vlan_proto, + ret = hclge_set_vlan_filter_hw(hdev, + htons(vlan_info->vlan_proto), vport->vport_id, vlan_info->vlan_tag, vlan_info->qos, false); @@ -6972,7 +6973,8 @@ int hclge_update_port_base_vlan_cfg(struct hclge_vport *vport, u16 state, return ret; /* remove old VLAN tag */ - ret = hclge_set_vlan_filter_hw(hdev, old_vlan_info->vlan_proto, + ret = hclge_set_vlan_filter_hw(hdev, + htons(old_vlan_info->vlan_proto), vport->vport_id, old_vlan_info->vlan_tag, old_vlan_info->qos, true);