From: Alexander Stein Date: Thu, 4 May 2023 06:53:16 +0000 (+0200) Subject: drm/bridge: ti-sn65dsi83: Fix enable error path X-Git-Tag: v6.6.17~3937^2~23^2~375 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8a91b29f1f50ce7742cdbe5cf11d17f128511f3f;p=platform%2Fkernel%2Flinux-rpi.git drm/bridge: ti-sn65dsi83: Fix enable error path If PLL locking failed, the regulator needs to be disabled again. Fixes: 5664e3c907e2 ("drm/bridge: ti-sn65dsi83: Add vcc supply regulator support") Signed-off-by: Alexander Stein Reviewed-by: Laurent Pinchart Signed-off-by: Robert Foss Link: https://patchwork.freedesktop.org/patch/msgid/20230504065316.2640739-1-alexander.stein@ew.tq-group.com --- diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 75286c9..1f5c079 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c @@ -478,6 +478,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge *bridge, dev_err(ctx->dev, "failed to lock PLL, ret=%i\n", ret); /* On failure, disable PLL again and exit. */ regmap_write(ctx->regmap, REG_RC_PLL_EN, 0x00); + regulator_disable(ctx->vcc); return; }