From: Thomas Schwinge Date: Fri, 24 Feb 2012 11:00:07 +0000 (+0000) Subject: * sh-tdep.c (sh_skip_prologue): Use skip_prologue_using_sal. X-Git-Tag: sid-snapshot-20120301~80 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8a8bc27fb314dbcbc75df4dc9f23bc83eeb64277;p=platform%2Fupstream%2Fbinutils.git * sh-tdep.c (sh_skip_prologue): Use skip_prologue_using_sal. (after_prologue): Remove. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e3cf077..8c6b20d 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2012-02-24 Thomas Schwinge + + * sh-tdep.c (sh_skip_prologue): Use skip_prologue_using_sal. + (after_prologue): Remove. + 2012-02-23 Tom Tromey * jv-valprint.c (java_val_print): Remove dead code. diff --git a/gdb/sh-tdep.c b/gdb/sh-tdep.c index 12116fd..489bb40 100644 --- a/gdb/sh-tdep.c +++ b/gdb/sh-tdep.c @@ -712,55 +712,29 @@ sh_analyze_prologue (struct gdbarch *gdbarch, } /* Skip any prologue before the guts of a function. */ - -/* Skip the prologue using the debug information. If this fails we'll - fall back on the 'guess' method below. */ -static CORE_ADDR -after_prologue (CORE_ADDR pc) -{ - struct symtab_and_line sal; - CORE_ADDR func_addr, func_end; - - /* If we can not find the symbol in the partial symbol table, then - there is no hope we can determine the function's start address - with this code. */ - if (!find_pc_partial_function (pc, NULL, &func_addr, &func_end)) - return 0; - - /* Get the line associated with FUNC_ADDR. */ - sal = find_pc_line (func_addr, 0); - - /* There are only two cases to consider. First, the end of the source line - is within the function bounds. In that case we return the end of the - source line. Second is the end of the source line extends beyond the - bounds of the current function. We need to use the slow code to - examine instructions in that case. */ - if (sal.end < func_end) - return sal.end; - else - return 0; -} - static CORE_ADDR -sh_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR start_pc) +sh_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc) { - CORE_ADDR pc; + CORE_ADDR post_prologue_pc, func_addr; struct sh_frame_cache cache; /* See if we can determine the end of the prologue via the symbol table. If so, then return either PC, or the PC after the prologue, whichever is greater. */ - pc = after_prologue (start_pc); + if (find_pc_partial_function (pc, NULL, &func_addr, NULL)) + { + post_prologue_pc = skip_prologue_using_sal (gdbarch, func_addr); + if (post_prologue_pc != 0) + return max (pc, post_prologue_pc); + } - /* If after_prologue returned a useful address, then use it. Else - fall back on the instruction skipping code. */ - if (pc) - return max (pc, start_pc); + /* Can't determine prologue from the symbol table, need to examine + instructions. */ cache.sp_offset = -4; - pc = sh_analyze_prologue (gdbarch, start_pc, (CORE_ADDR) -1, &cache, 0); - if (!cache.uses_fp) - return start_pc; + post_prologue_pc = sh_analyze_prologue (gdbarch, pc, (CORE_ADDR) -1, &cache, 0); + if (cache.uses_fp) + pc = post_prologue_pc; return pc; }