From: Mario Limonciello Date: Wed, 26 Jan 2022 03:46:58 +0000 (-0600) Subject: drm/amd: avoid suspend on dGPUs w/ s2idle support when runtime PM enabled X-Git-Tag: accepted/tizen/unified/20230118.172025~2582 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8a15ac1786c92dce6ecbeb4e4c237f5f80c2c703;p=platform%2Fkernel%2Flinux-rpi.git drm/amd: avoid suspend on dGPUs w/ s2idle support when runtime PM enabled commit e55a3aea418269266d84f426b3bd70794d3389c8 upstream. dGPUs connected to Intel systems configured for suspend to idle will not have the power rails cut at suspend and resetting the GPU may lead to problematic behaviors. Fixes: e25443d2765f4 ("drm/amdgpu: add a dev_pm_ops prepare callback (v2)") Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1879 Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello Signed-off-by: Alex Deucher Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 41677f9..30059b7 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c @@ -1504,8 +1504,7 @@ static int amdgpu_pmops_prepare(struct device *dev) * DPM_FLAG_SMART_SUSPEND works properly */ if (amdgpu_device_supports_boco(drm_dev)) - return pm_runtime_suspended(dev) && - pm_suspend_via_firmware(); + return pm_runtime_suspended(dev); return 0; }