From: Archit Taneja Date: Tue, 18 Feb 2014 13:24:07 +0000 (-0300) Subject: upstream: [media] v4l: ti-vpe: Use video_device_release_empty X-Git-Tag: submit/tizen/20141121.110247~1305 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8a10572cff59dca1203455ec7055bb87fa64da34;p=platform%2Fkernel%2Flinux-3.10.git upstream: [media] v4l: ti-vpe: Use video_device_release_empty The video_device struct is currently embedded in the driver data struct vpe_dev. A vpe_dev instance is allocated by the driver, and the memory for the vfd is a part of this struct. The v4l2 core, however, manages the removal of the vfd region, through the video_device's .release() op, which currently is the helper video_device_release. This causes memory corruption, and leads to issues when we try to re-insert the vpe module. Use the video_device_release_empty helper function instead. Reviewed-by: Hans Verkuil Signed-off-by: Archit Taneja Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index aa752d8..0fb811e 100644 --- a/drivers/media/platform/ti-vpe/vpe.c +++ b/drivers/media/platform/ti-vpe/vpe.c @@ -1930,7 +1930,7 @@ static struct video_device vpe_videodev = { .fops = &vpe_fops, .ioctl_ops = &vpe_ioctl_ops, .minor = -1, - .release = video_device_release, + .release = video_device_release_empty, .vfl_dir = VFL_DIR_M2M, };