From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 8 Apr 2012 22:41:10 +0000 (+0000)
Subject: net/key/af_key.c: add missing kfree_skb
X-Git-Tag: v3.12-rc1~3345^2~44
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=89eb06f11c314c2ab4ec59039715dc021933a7a0;p=kernel%2Fkernel-generic.git

net/key/af_key.c: add missing kfree_skb

At the point of this error-handling code, alloc_skb has succeded, so free
the resulting skb by jumping to the err label.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/key/af_key.c b/net/key/af_key.c
index 11dbb22..7e5d927 100644
--- a/net/key/af_key.c
+++ b/net/key/af_key.c
@@ -3480,7 +3480,7 @@ static int pfkey_send_migrate(const struct xfrm_selector *sel, u8 dir, u8 type,
 
 	/* Addresses to be used by KM for negotiation, if ext is available */
 	if (k != NULL && (set_sadb_kmaddress(skb, k) < 0))
-		return -EINVAL;
+		goto err;
 
 	/* selector src */
 	set_sadb_address(skb, sasize_sel, SADB_EXT_ADDRESS_SRC, sel);