From: Dmitry Antipov Date: Wed, 2 Aug 2023 17:04:09 +0000 (+0300) Subject: wifi: ath12k: relax list iteration in ath12k_mac_vif_unref() X-Git-Tag: v6.6.17~4098^2~214^2^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=89a9dda1430a71fe95ad2b4f8056e7aa15b4aee7;p=platform%2Fkernel%2Flinux-rpi.git wifi: ath12k: relax list iteration in ath12k_mac_vif_unref() In ath12k_mac_vif_unref() dp->tx_desc_used_list[i] is not altered so list_for_each_entry() should be safe. Signed-off-by: Dmitry Antipov Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20230704173718.73462-1-dmantipov@yandex.ru --- diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c index 48cf3f1..0f2af2f 100644 --- a/drivers/net/wireless/ath/ath12k/mac.c +++ b/drivers/net/wireless/ath/ath12k/mac.c @@ -5542,7 +5542,7 @@ err: static void ath12k_mac_vif_unref(struct ath12k_dp *dp, struct ieee80211_vif *vif) { - struct ath12k_tx_desc_info *tx_desc_info, *tmp1; + struct ath12k_tx_desc_info *tx_desc_info; struct ath12k_skb_cb *skb_cb; struct sk_buff *skb; int i; @@ -5550,8 +5550,8 @@ static void ath12k_mac_vif_unref(struct ath12k_dp *dp, struct ieee80211_vif *vif for (i = 0; i < ATH12K_HW_MAX_QUEUES; i++) { spin_lock_bh(&dp->tx_desc_lock[i]); - list_for_each_entry_safe(tx_desc_info, tmp1, &dp->tx_desc_used_list[i], - list) { + list_for_each_entry(tx_desc_info, &dp->tx_desc_used_list[i], + list) { skb = tx_desc_info->skb; if (!skb) continue;