From: Peter Oberparleiter Date: Mon, 18 May 2015 12:27:59 +0000 (+0200) Subject: s390/lcs: Fix null-pointer access in msg X-Git-Tag: v4.2~362^2~264^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=89a2a8e76b8193fe282c472f1da259e0075476f7;p=platform%2Fkernel%2Flinux-amlogic.git s390/lcs: Fix null-pointer access in msg An attempt to configure a CTC device as LCS results in the following error message: (null): Detecting a network adapter for LCS devices failed with rc=-5 (0xfffffffb) "(null)" results from access to &card->dev->dev in lcs_new_device() which is only initialized later in the function. Fix this by using &ccwgdev->dev instead which is initialized before lcs_new_device() is called. Signed-off-by: Peter Oberparleiter Signed-off-by: Ursula Braun Signed-off-by: David S. Miller --- diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c index 00b7d9c..2f5b518 100644 --- a/drivers/s390/net/lcs.c +++ b/drivers/s390/net/lcs.c @@ -2150,7 +2150,7 @@ lcs_new_device(struct ccwgroup_device *ccwgdev) rc = lcs_detect(card); if (rc) { LCS_DBF_TEXT(2, setup, "dtctfail"); - dev_err(&card->dev->dev, + dev_err(&ccwgdev->dev, "Detecting a network adapter for LCS devices" " failed with rc=%d (0x%x)\n", rc, rc); lcs_stopcard(card);